[riot-notifications] [RIOT-OS/RIOT] sc_gnrc_ipv6_nib: check interface existence [backport 2019.01] (#10886)
notifications at github.com
Mon Jan 28 09:47:55 CET 2019
# Backport of #10879
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
Currently an interface's existence is not checked when it is supplied
by the user with the `nib` command. This can lead to assertion errors
as soon as the generated entry tries to resolve an address or route
generated with that command and the network interface not being found.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
Run `gnrc_networking` on any board and try to add a neighbor/prefix/route to an interface that does not exist. Without this PR you will succeed, worse even, if you send to that neighbor/prefix/route the node will run into a failed assertion within the `nib`. With this PR an error message will be printed, that the interface does not exist.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* sc_gnrc_ipv6_nib: check interface existence
-- File Changes --
M sys/shell/commands/sc_gnrc_ipv6_nib.c (37)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications