[riot-notifications] [RIOT-OS/RIOT] boards/nrf52xxxdk: add openocd as programmer option (#9407)

Marian Buschsieweke notifications at github.com
Mon Jan 28 17:22:28 CET 2019


maribu requested changes on this pull request.

Couldn't the OpenOCD config be placed into `boards/common/nrf52` instead of `boards/common/nrf52xxxdk` to allow more boards sharing the same config file?

Can you rebase and remove the OpenOCD config of the nref52840-mdk boards in favor of the OpenOCD config provided by this PR?

> +PROGRAMMER ?= jlink
+ifeq (jlink,$(PROGRAMMER))
+  # setup JLink for flashing
+  export JLINK_DEVICE := nrf52
+
+  # special options when using SoftDevice
+  ifneq (,$(filter nordic_softdevice_ble,$(USEPKG)))
+    export JLINK_PRE_FLASH := erase\nloadfile $(BINDIR)/softdevice.hex
+    export FLASH_ADDR := 0x1f000
+    export LINKER_SCRIPT ?= $(RIOTCPU)/$(CPU)/ldscripts/$(CPU_MODEL)_sd.ld
+  endif
+  include $(RIOTMAKE)/tools/jlink.inc.mk
+else ifeq (openocd,$(PROGRAMMER))
+  # setup OpenOCD for flashing. Version 0.10 of OpenOCD doesn't contain support
+  # for nrf52dk and nrf52840dk boards. To use OpenOCD with these a version
+  # build from source (master > 2018, August the 13rd) is required.

I would put this info in Doxygen, as users will be more likely to see it there. Feel free to use https://github.com/RIOT-OS/RIOT/pull/10890/commits/740814a62cfd7f5a62c03958783e2b2e99015016

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9407#pullrequestreview-197126570
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190128/f7794a63/attachment-0001.html>


More information about the notifications mailing list