[riot-notifications] [RIOT-OS/RIOT] net stats: move layer 2 netstats from netdev driver to gnrc_netif (#9793)

Sebastian Meiling notifications at github.com
Tue Jan 29 10:22:57 CET 2019


smlng commented on this pull request.



> @@ -356,7 +355,7 @@ int gnrc_gomach_send_preamble_ack(gnrc_netif_t *netif, gnrc_gomach_packet_info_t
      * This is to allow the preamble sender to deduce the exact phase of the receiver. */
     gomach_preamble_ack_hdr.phase_in_us = gnrc_gomach_phase_now(netif);
 
-    pkt = gnrc_pktbuf_add(NULL, &gomach_preamble_ack_hdr, sizeof(gomach_preamble_ack_hdr),
+    gnrc_pktsnip_t *pkt = gnrc_pktbuf_add(NULL, &gomach_preamble_ack_hdr, sizeof(gomach_preamble_ack_hdr),

In theory yes, as it is not related to netstats. However, as I touched the file the static code analyser found (that is: complained) that the previous value of `pkt` (which is `NULL` see above) was not used before being overwritten. To me this seems a bit overly correct, but in the end I need to please the CI to get the green button.

TL;DR: change is necessary to make CI happy 😦 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9793#discussion_r251749218
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190129/088b4bdd/attachment.html>


More information about the notifications mailing list