[riot-notifications] [RIOT-OS/RIOT] tests/gnrc_sock_dns: port to scapy (#10898)

Alexandre Abadie notifications at github.com
Wed Jan 30 09:22:16 CET 2019


> sudo make test

I have to say that I don't like this. The files generated by the build (if the application was not built already) will be owned by root and it will create a mess with file permissions in the riot directory. For me this is also a big problem with automated tests but also for developers without root access on their machine. The same issue is already in master with 2 other gnrc test applications.
The fact that it passes on Murdock is probably because the tests are run within a container environment, using a root user. This doesn't reflect the way a developer is supposed to use the build system to test something.
Running tests as root could cause many troubles, just imagine a line that just do `os.system('rm -rf /')`.

If there is a way to use scapy without the need to be root, that would be more useful and it should also be documented.

The purpose of tests is to be runnable by any developer, without strong knowledge of all the corner cases and setup details. It should also be easy to understand and help understand the code being tested.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10898#issuecomment-458853566
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190130/8ffb978b/attachment.html>


More information about the notifications mailing list