[riot-notifications] [RIOT-OS/RIOT] [RFC] gnrc_tcp_recv(): fix connection closed by remote host not handled (#10899)

Simon Brummer notifications at github.com
Wed Jan 30 10:06:40 CET 2019


brummer-simon requested changes on this pull request.

I took a brief look into the TCP RFC regarding the handling of the receive call (https://tools.ietf.org/html/rfc793#page-59). Your bug fix is not consistent with the specified behavior.

It is possible that an incoming packet with FIN set contains payload. This means there could be received data in the TCB.  The early return would make already received data in CLOSE-WAIT state unavailable to the calling code.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10899#pullrequestreview-197965681
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190130/e5dffb68/attachment.html>


More information about the notifications mailing list