[riot-notifications] [RIOT-OS/RIOT] pkg/semtech-loramac: improve TX status management after sending a message (#10903)

Leandro Lanzieri notifications at github.com
Wed Jan 30 16:11:00 CET 2019


leandrolanzieri requested changes on this pull request.



> @@ -834,7 +834,14 @@ uint8_t semtech_loramac_send(semtech_loramac_t *mac, uint8_t *data, uint8_t len)
 
     _semtech_loramac_call(_send, &params);
 
-    return SEMTECH_LORAMAC_TX_SCHEDULE;
+    /* Wait for TX status information from the MAC */

I think setting the `caller_pid` before calling `_semtech_loramac_call(...)` is missing, otherwise the msg never arrives
```C
mac->caller_pid = thread_getpid();
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10903#pullrequestreview-198126753
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190130/a1e37165/attachment-0001.html>


More information about the notifications mailing list