[riot-notifications] [RIOT-OS/RIOT] boards: add samr30-xpro board and samr30 cpu (#9437)

Kees Bakker notifications at github.com
Thu Jan 31 20:09:40 CET 2019


@biboc @dylad
Well, the thing is, the method to copy vendor files was changed, back in 2017. Before c5cbc42 it was as it is described in the README of samr30. It's something I described for samd21 and the samr30 README is basically a copy of that.
Since c5cbc42 we simply copy the files verbatim (i.e. unchanged) from ASF into RIOT. In all cases we describe what ASF version was used, or whatever source was used.

Furthermore I am unhappy of the fact that the samr30 files are from ASF 3.34.2. I believe that was totally unnecessary.

You may think: who cares, but I see great value in documenting. When we want to pull in updates from newer ASF we need to know what changed. Each ASF can have potential bug fixes, which is also the case for 3.34.2 => 3.35.1
```
-typedef volatile       uint32_t WoReg8;  /**< Write only  8-bit register (volatile unsigned int) */
+typedef volatile       uint8_t  WoReg8;  /**< Write only  8-bit register (volatile unsigned int) */
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9437#issuecomment-459467596
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190131/4f918c56/attachment.html>


More information about the notifications mailing list