[riot-notifications] [RIOT-OS/RIOT] tests: add tests to reproduce #10881 (#10908)

Martine Lenders notifications at github.com
Thu Jan 31 22:38:13 CET 2019


miri64 commented on this pull request.



> +# Copyright (C) 2019 Freie Universit├Ąt Berlin
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+
+import sys
+from testrunner import run
+from pexpect import TIMEOUT
+
+
+def testfunc(child):
+    res = child.expect([TIMEOUT, "FAILED ASSERTION."])
+    # we actually want the timeout here. The application runs into an assertion
+    # pretty quickly when failing and runs forever on success
+    assert(res == 0)

Yepp, but if and return are not function-like. As I said: we don't follow the common style guidelines for `sizeof` either and I'm not gonna start. Can we please stop this discussions about minor personal style disagreements and focus on the actual quality of the code. The maintainer guidelines even point out to look at this first and at style later. Once https://github.com/RIOT-OS/RIOT/pull/10431 is merged I would replace this with an assertRaises() anyway so this discussion isn't even future-proof. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10908#discussion_r252850691
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190131/3988ffc6/attachment.html>


More information about the notifications mailing list