[riot-notifications] [RIOT-OS/RIOT] make: add termdeps target (#11762)

Francisco notifications at github.com
Mon Jul 1 09:43:02 CEST 2019


fjmolinas commented on this pull request.

> AFAIK currently no test is using ethos, thus ideally, nothing will change for now.

Three tests use ethos right now:

- tests/gnrc_sock_dns
- tests/gnrc_rpl_srh
- tests/gnrc_ipv6_ext

None of these are affected by the problem you mention because they query the device instead of waiting for input on startup. But in any case the test time should be shorter for these since the termdeps are being built in parallel. I tried to check the result of murdock runs on this PR vs others, but since it isn't deterministic I can't really confirm it is faster.

This PR:

`runtime: total=14m:46.8s min=1.2s max=20.7s avg=5.6s`

Other PR:

```
runtime: total=19m:47.2s min=1.6s max=22.4s avg=7.6s
runtime: total=18m:16.0s min=1.3s max=20.3s avg=7.0s
runtime: total=13m:30.9s min=1.0s max=15.3s avg=5.2s
runtime: total=16m:07.1s min=1.6s max=47.0s avg=6.2s
```

@kaspar030 is there a way to get better evidence of the speed up?

I also tested locally that `make termdeps` was working for these tests.

In any case I see no harm for this PR. But if we can get evidence of it speeding up the tests I think it is better since right now the use case isn't clear with this PR in isolation.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11762#pullrequestreview-256176048
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190701/5168fe64/attachment.html>


More information about the notifications mailing list