[riot-notifications] [RIOT-OS/RIOT] drivers/sx127x: fix device reset (#11678)

MichelRottleuthner notifications at github.com
Mon Jul 1 13:10:59 CEST 2019


MichelRottleuthner commented on this pull request.



>      _init_timers(dev);
-    xtimer_usleep(1000); /* wait 1 millisecond */
+
+    /* reset pin should be left floating during POR */
+    gpio_init(dev->params.reset_pin, GPIO_IN);
+
+    /* wait till device signals end of POR cycle */
+    while ((gpio_read(dev->params.reset_pin) > 0) ==

For the sx1276 you are right. But for sx1272 it's inverted and you need to consider that the gpio api either returns 0 or some number >0

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11678#discussion_r298992811
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190701/cbbbe769/attachment.html>


More information about the notifications mailing list