[riot-notifications] [RIOT-OS/RIOT] gnrc_tftp: initialize unititialized 'tftp_context_t' (#11773)

Martine Lenders notifications at github.com
Mon Jul 1 23:07:20 CEST 2019


miri64 commented on this pull request.



> @@ -606,6 +608,7 @@ tftp_state _tftp_state_processes(tftp_context_t *ctxt, msg_t *m)
     tmp = gnrc_pktsnip_search_type(pkt, GNRC_NETTYPE_IPV6);
     ipv6_hdr_t *ip = (ipv6_hdr_t *)tmp->data;
     uint8_t *data = (uint8_t *)pkt->data;
+    ctxt->dst_port = byteorder_ntohs(udp->src_port);

I'm not 100% sure about this one. There are also other sets of this variable below... However, I observed `gnrc_udp_hdr_build()` getting `dst_port` 0 with the fix above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11773#pullrequestreview-256561979
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190701/70bbbba6/attachment.html>


More information about the notifications mailing list