[riot-notifications] [RIOT-OS/RIOT] stm32_common/flashpage: fix stm32l4 erase error & EOP clear (#11776)

Alexandre Abadie notifications at github.com
Thu Jul 4 08:20:24 CEST 2019


aabadie commented on this pull request.

I checked the datasheet of several STMs and confirm the changes make sense. Some changes in this PR are affecting all STMs that have flashpage support, so need to be tested (not only stm32l4 as mentioned in the PR title)

> @@ -67,6 +67,7 @@ void _wait_for_pending_operations(void)
 
     /* Clear 'end of operation' bit in status register */
     if (FLASH->SR & FLASH_SR_EOP) {
-        FLASH->SR &= ~(FLASH_SR_EOP);
+        FLASH->SR |= FLASH_SR_EOP;

Maybe we could just remove the if line above and just keep this line?

>      }
+

unrelated

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11776#pullrequestreview-257844993
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190703/1d3a5767/attachment.html>


More information about the notifications mailing list