[riot-notifications] [RIOT-OS/RIOT] stm32_common/flashpage: fix stm32l4 erase error & EOP clear (#11776)

Francisco notifications at github.com
Thu Jul 4 09:37:17 CEST 2019


fjmolinas commented on this pull request.



> @@ -67,6 +67,7 @@ void _wait_for_pending_operations(void)
 
     /* Clear 'end of operation' bit in status register */
     if (FLASH->SR & FLASH_SR_EOP) {
-        FLASH->SR &= ~(FLASH_SR_EOP);
+        FLASH->SR |= FLASH_SR_EOP;

We could do this and guard it for STM32F2, STM32F4, STM32F7 & STM32L4 since EOPIE is not set this is not needed for these platforms, a proper commit comment would justify and documment in case in a future EOPIE are used. What do you think?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11776#discussion_r300265685
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190704/3ee90e51/attachment-0001.html>


More information about the notifications mailing list