[riot-notifications] [RIOT-OS/RIOT] pic32-wifire: add support for flashing with pic32prog (#9259)

Kaspar Schleiser notifications at github.com
Thu Jul 4 13:55:31 CEST 2019

kaspar030 requested changes on this pull request.

Works fine here, apart from the pic32 compilation process trying to link a static libusb-1.0 library on arch. That's an upstream problem, though.

- update pic32prog PKG_VERSION
- maybe change PIC32PROG binary selection logic to work like with edbg, dfu. While compiling this list I realize that we're not consistent throughout the code base, so maybe postpone or ignore.

> @@ -0,0 +1,19 @@
+PKG_NAME     = pic32prog
+PKG_URL      = https://github.com/sergev/pic32prog
+PKG_VERSION  = f5d27d6c9506bc0d1f2053002e2aadad1ac424cd

I tried current upstream, also works. current master commit is "b9f8db3b352804392b02b42475fc42874ac8bf04"

> +# ATTR{idVendor}=="04d8", MODE="664", GROUP="plugdev"
+# ```
+PIC32PROG = $(RIOTTOOLS)/pic32prog/pic32prog
+# No reset command, but the board resets on terminal open
+# Compile pic32prog if using the one provided in RIOT
+FLASHDEPS += $(if $(findstring $(PIC32PROG),$(FLASHER)),$(PIC32PROG))

Please change the FLASHDEPS logic to something like:
RIOT_PIC32PROG = $(RIOTTOOLS)/pic32prog/pic32prog
ifeq ($(PIC32PROG), $(RIOT_PIC32PROG))
  FLASHDEPS += pic32prog

As is it doesn't work when overriding with "PIC32PROG=pic32prog make ...". This is how we usually do it with other tools (edbg, ...), not by overriding FLASHER directly.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190704/762592b4/attachment-0001.html>

More information about the notifications mailing list