[riot-notifications] [RIOT-OS/RIOT] stm32_common/stm32_mem_length: fix RAM_LEN for stm32l1xx-A/X cpu's (#11794)

Francisco notifications at github.com
Thu Jul 4 15:34:14 CEST 2019

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description

Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

STM32L1 cpu's sometimes have a `-A/X` in the product name, this changes the amount of RAM on some of these boards. Currently some product names are incorrectly defined according to the specification, e.g: `lobaro-lorabox` `CPU_MODEL=stm32l151cb` when it is actually `stm32l151cb-a`, the first version having 16kB and the second 32 kB (NOTE: since in master the RAM for stm32l151cb is wrongly defined there isn't any functional problem, but incorrect definitions). The parsing script has been updated to include the suffix.

### Testing procedure

Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

Check STM32 documentation to verify the combinations:


To verify `RAM_LEN` you can change the `CPU_MODEL` variable while running:

CPU_MODEL=stm32l151cb_a RIOT_MAKEFILES_GLOBAL_POST="/home/francisco/workspace/RIOT/cpu/stm32_common/Makefile.include" make -C examples/hello-world/ info-stm32

and check the output is correct:

CPU: stm32l151cb_a
        Line: STM32L151xx
        Pin count:      48
        ROM size:       128K (131072 Bytes)
        RAM size:       32K
### Issues/PRs references

Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * stm32_common/stm32_mem_length: fix RAM_LEN for stm32l1xx-A/X cpu's
  * boards/lobaro-lorabox: add -A suffix to CPU_MODEL

-- File Changes --

    M boards/lobaro-lorabox/Makefile.include (2)
    M cpu/stm32_common/stm32_mem_lengths.mk (25)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190704/cfe688f1/attachment.html>

More information about the notifications mailing list