[riot-notifications] [RIOT-OS/RIOT] pkg/nimble: add IP-over-BLE support via netif/GNRC (#11578)

Martine Lenders notifications at github.com
Fri Jul 5 18:06:30 CEST 2019


miri64 requested changes on this pull request.



> @@ -42,3 +43,14 @@ ifneq (,$(filter nimble_scanlist,$(USEMODULE)))
   USEMODULE += nimble_addr
   USEMODULE += bluetil_ad
 endif
+
+ifneq (,$(filter nimble_netif,$(USEMODULE)))
+  USEMODULE += l2util
+  USEMODULE += nimble_svc_ipss
+  ifneq (,$(filter gnrc_ipv6_router_default,$(USEMODULE)))
+    USEMODULE += gnrc_sixlowpan_router_default

I'm sorry, I know I told you to do so, but this pulls in `gnrc_sixlowpan_frag` in as well. Better do it by hand:

```suggestion
  USEMODULE += gnrc_ipv6_nib_6lr
  USEMODULE += gnrc_sixlowpan
  USEMODULE += gnrc_sixlowpan_iphc
```

> @@ -42,3 +43,14 @@ ifneq (,$(filter nimble_scanlist,$(USEMODULE)))
   USEMODULE += nimble_addr
   USEMODULE += bluetil_ad
 endif
+
+ifneq (,$(filter nimble_netif,$(USEMODULE)))
+  USEMODULE += l2util
+  USEMODULE += nimble_svc_ipss
+  ifneq (,$(filter gnrc_ipv6_router_default,$(USEMODULE)))
+    USEMODULE += gnrc_sixlowpan_router_default
+  endif
+  ifneq (,$(filter gnrc_ipv6_default,$(USEMODULE)))
+    USEMODULE += gnrc_sixlowpna_default

Same here (also: there is a typo)

```suggestion
  USEMODULE += gnrc_ipv6_nib_6ln
  USEMODULE += gnrc_sixlowpan
  USEMODULE += gnrc_sixlowpan_iphc
```

> @@ -42,3 +43,14 @@ ifneq (,$(filter nimble_scanlist,$(USEMODULE)))
   USEMODULE += nimble_addr
   USEMODULE += bluetil_ad
 endif
+
+ifneq (,$(filter nimble_netif,$(USEMODULE)))
+  USEMODULE += l2util
+  USEMODULE += nimble_svc_ipss
+  ifneq (,$(filter gnrc_ipv6_router_default,$(USEMODULE)))
+    USEMODULE += gnrc_sixlowpan_router_default

Also considering that that RFC 7668 [explicitly forbids 6LRs](https://tools.ietf.org/html/rfc7668#section-3) maybe make it `gnrc_ipv6_nib_6ln` instead of `gnrc_ipv6_nib_6lr`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11578#pullrequestreview-258473033
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190705/9531a671/attachment-0001.html>


More information about the notifications mailing list