[riot-notifications] [RIOT-OS/RIOT] pkg/openthread: remove openthread config header from contrib (#11817)

José Alamos notifications at github.com
Mon Jul 8 15:22:35 CEST 2019


### Contribution description

This PR removes the inclusion of the OpenThread config file in `openthread/contrib` C files.
The internal Openthread config file is not needed for the contrib
files, since it only includes internal OpenThread configuration
(use by the Openthread build system). Under certain cases some
macros defined in Openthread collide with RIOT internals or vendor
headers (see #11770). So it's important to keep the dependencies consistent.
<!--
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
-->

<!--
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
-->


### Testing procedure
Compile the Openthread example with `samr21-xpro` or `iotlab-m3`. Check there are no compilation errors.
<!--
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
-->


### Issues/PRs references
#11770
<!--
Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
-->

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/11817

-- Commit Summary --

  * pkg/openthread: remove openthread header from contrib

-- File Changes --

    M pkg/openthread/contrib/platform_logging.c (1)
    M pkg/openthread/contrib/platform_radio.c (1)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/11817.patch
https://github.com/RIOT-OS/RIOT/pull/11817.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11817
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190708/ee0ae0b6/attachment.html>


More information about the notifications mailing list