[riot-notifications] [RIOT-OS/RIOT] Makefile.include: remove RIOT_VERSION_OVERRIDE (#11771)

Gaëtan Harter notifications at github.com
Mon Jul 8 18:25:06 CEST 2019


I handled it with a `warning` and kept the old behavior when set.
Should I put a removal date ?

It will still evaluate `git describe` as I wanted to put the handling near original usage.

Testing procedure for the deprecation handling:

```
RIOT_VERSION_OVERRIDE=manually_set make --no-print-directory -C examples/hello-world/ info-debug-variable-RIOT_VERSION info-debug-variable-CFLAGS_WITH_MACROS 
/home/harter/work/git/worktree/riot_test/examples/hello-world/../../Makefile.include:723: 'RIOT_VERSION_OVERRIDE' is deprecated, it can now be set with 'RIOT_VERSION' directly.
manually_set
-DDEVELHELP -Werror -Wall -Wextra -pedantic -std=gnu99 -m32 -fstack-protector-all -ffunction-sections -fdata-sections -DDEBUG_ASSERT_VERBOSE -DRIOT_APPLICATION="hello-world" -DBOARD_NATIVE="native" -DRIOT_BOARD=BOARD_NATIVE -DCPU_NATIVE="native" -DRIOT_CPU=CPU_NATIVE -DMCU_NATIVE="native" -DRIOT_MCU=MCU_NATIVE -fno-delete-null-pointer-checks -fdiagnostics-color -Wstrict-prototypes -Wold-style-definition -fno-common -Wall -Wextra -Wformat=2 -Wformat-overflow -Wformat-truncation -Wmissing-include-dirs -DMODULE_AUTO_INIT -DMODULE_BOARD -DMODULE_CORE -DMODULE_CORE_MSG -DMODULE_CPU -DMODULE_NATIVE_DRIVERS -DMODULE_PERIPH -DMODULE_PERIPH_COMMON -DMODULE_PERIPH_GPIO -DMODULE_PERIPH_PM -DMODULE_PERIPH_UART -DMODULE_SYS -DRIOT_VERSION="manually_set"
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11771#issuecomment-509295723
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190708/f61305f1/attachment.html>


More information about the notifications mailing list