[riot-notifications] [RIOT-OS/RIOT] sys/suit: initial support for SUIT firmware updates (#11818)

Francisco notifications at github.com
Wed Jul 10 12:37:12 CEST 2019


fjmolinas commented on this pull request.



> +            return;
+        }
+
+        printf("suit_v4_parse() success\n");
+        if (!(manifest.state & SUIT_MANIFEST_HAVE_IMAGE)) {
+            puts("manifest parsed, but no image fetched");
+            return;
+        }
+
+        res = suit_v4_policy_check(&manifest);
+        if (res) {
+            return;
+        }
+
+#endif
+        if (res == 0) {

While reviewing #11805 I realized `res` is uninitialized if `MODULE_SUIT_V4` is not used.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11818#pullrequestreview-260008304
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190710/d8c2ba71/attachment.html>


More information about the notifications mailing list