[riot-notifications] [RIOT-OS/RIOT] gnrc_netif: allow for wait of minimum time between sends (#11837)
notifications at github.com
Fri Jul 12 17:04:41 CEST 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
This was cherry-picked out of #11068 (which became a huge mess during my experiment phase in preparation for [the 6LoWPAN fragment forwarding paper](https://arxiv.org/abs/1905.08089).
This adds a minimum sleep between every send, to allow for slowing down the send operations of a device.
To be perfectly honest, I don't know if and how useful this could be in production operation or beyond experimentation in general, but I helped me to confirm some things during my experimentation. However, I kept it optional and marked it as experimental so I think it does not harm to merge.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
First compile and flash `gnrc_networking` normally with `GNRC_NETIF_MIN_WAIT_AFTER_SEND_US=0`. Ping another node with the same configuration. There should be no significant changes to to master.
Now compile with a higher delay e.g. `GNRC_NETIF_MIN_WAIT_AFTER_SEND_US=5000`. The RTT when pinging should now significantly increase (maybe even timeout), if you have access two a sniffer: the time different between two transmissions (ignoring L2 retransmissions) should now be at minimum at the configured time interval.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Cherry-picked from #11068, but this PR has no dependencies.
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* gnrc_netif: allow for wait of minimum time between sends
-- File Changes --
M sys/include/net/gnrc/netif/conf.h (11)
M sys/net/gnrc/netif/gnrc_netif.c (11)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications