[riot-notifications] [RIOT-OS/RIOT] dist/tools/git/git-cache: bump version (#11841)

Kaspar Schleiser notifications at github.com
Mon Jul 15 12:16:32 CEST 2019


<!--
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
-->

### Contribution description

Upstream contains important fixes:

- improve tag handling

Previously, a checkout from cache included all tags from all cached repositories, but with a repository-hash in front.
This lead to duplicate tag entries:

```
    $ cd tests/pkg_libcose
    $ make
    $ cd bin/pkg/native/libcose
    $ git describe
```

master:
```
[kaspar at ng libcose ((542ba36478...))]$ git describe
warning: tag 'v0.3.1' is really '4b5e2db9542f5884bab62b37b874bbdeafbe9c62/v0.3.1' here
v0.3.1-1-g542ba36478
[kaspar at ng libcose ((542ba36478...))]$
```

this PR:
```
[kaspar at ng libcose ((62e41ab711...))]$ git describe
v0.3.1-1-g62e41ab711
[kaspar at ng libcose ((62e41ab711...))]$ 
```

Not the missing "warning: tag X is really Y here" warning. The warning broke anything within a package depending on "git describe" output, e.g., the micropython Makefiles.

(the actual commit hash differs, as a patch is applied on top using git am.)

- improve concurrent use

previously, git-cache would, if a commit hash was requested for checkout create a temporary tag ```commit<hash>``` so it has a named ref. The logic wouldn't work with multiple concurrent calls.
This has been fixed by appending the PID of git-cache to the temporary tag.

- clean up temporary tags

Well, previously the tags weren't really temporary, cluttering the tag space with leftovers. Now they get properly cleaned after checkout.

<!--
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
-->


### Testing procedure

CI has been using this since a long time (it is part of the murdock container), so I don't expect much trouble.
Anyhow, for testing, try building ```tests/pkg_*``` for all tests using git, especially those using tags instead of commit hashes.
(Ensure git-cache is enabled: ```git-cache init```).

<!--
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
-->


### Issues/PRs references

<!--
Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
-->

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/11841

-- Commit Summary --

  * dist/tools/git/git-cache: bump version

-- File Changes --

    M dist/tools/git/git-cache (31)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/11841.patch
https://github.com/RIOT-OS/RIOT/pull/11841.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11841
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190715/65454ea5/attachment.html>


More information about the notifications mailing list