[riot-notifications] [RIOT-OS/RIOT] net/nanocoap: document internal option functions (#11839)

Kaspar Schleiser notifications at github.com
Tue Jul 16 09:56:31 CEST 2019


kaspar030 commented on this pull request.



> @@ -176,6 +176,18 @@ uint8_t *coap_find_option(const coap_pkt_t *pkt, unsigned opt_num)
     return NULL;
 }
 
+/*
+ * Parse option attributes
+ *
+ * pkt[in]           coap_pkt_t for buffer
+ * pkt_pos[in,out]   in: first byte of option in buffer

how can this be "out"? It is a pointer, not pointer to pointer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11839#pullrequestreview-262242948
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190716/ef3d64f1/attachment.html>


More information about the notifications mailing list