[riot-notifications] [RIOT-OS/RIOT] dist/tests/philip: Removed old code and tests (#11767)

Sebastian Meiling notifications at github.com
Thu Jul 18 10:57:00 CEST 2019


smlng requested changes on this pull request.



> -`python test.py --log=DEBUG --dut_port="/dev/ttyACM0" --dut_baud=9600 --bpt_port="/dev/ttyACM1" > nucleo-f401_test.txt` for all the fix'ns</br>
-
-Flags
-==========
---log=DEBUG -> allows for debug output</br>
---dut_port -> the port name of the DUT</br>
---dut_baud -> the baud rate of the DUT</br>
---bpt_port -> the port name of the BPT
-
-Notes
-==========
-- If no serial connection to the BPT the test should still be able to run, it just will not be able to reset.
-- Connect the SDA, SCL and if possible the DUT reset pin.
-- Autoconnect *may* work if no ports are specified.
-- Default baud rate is 115200
+Automated tests can be found in the

I would suggest the following:

- move this comment to (if exists) the main README in the main folder of the test application
- if no README there, create one with (at least) these few lines
- And remove the `tests` subfolder.

> -Flags
-==========
---log=DEBUG -> allows for debug output</br>
---dut_port -> the port name of the DUT</br>
---dut_baud -> the baud rate of the DUT</br>
---bpt_port -> the port name of the BPT
-
-Notes
-==========
-- If no serial connection to the BPT the test should still be able to run, it just will not be able to reset.
-- Connect the SDA, SCL and if possible the DUT reset pin.
-- Autoconnect *may* work if no ports are specified.
-- Default baud rate is 115200
+Automated tests can be found in the
+[RobotFW-tests](https://github.com/RIOT-OS/RobotFW-tests/tree/master/tests/periph_i2c)
+area

nit-picky: /area/repository/ ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11767#pullrequestreview-263516279
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190718/05067d19/attachment.htm>


More information about the notifications mailing list