[riot-notifications] [RIOT-OS/RIOT] boards/openmote-b: Fix flashing issues (#11833)

Gaëtan Harter notifications at github.com
Fri Jul 19 11:36:22 CEST 2019


cladmi commented on this pull request.

Minor formatting nitpicks in the Makefile.
Otherwise the changes are good for me.


>    FLASHER = $(RIOTBASE)/dist/tools/cc2538-bsl/cc2538-bsl.py
   FFLAGS  = -p "$(PORT_BSL)" --bootloader-invert-lines -e -w -v -b 460800 $(FLASHFILE)
+  RESET_FLAGS ?= -p "$(PORT_BSL)" --bootloader-invert-lines

Maybe RESET_FLAGS after RESET to keep standards.

>  else ifeq ($(PROGRAMMER),jlink)
-  FLASHER = $(RIOTBOARD)/$(BOARD)/dist/flash.sh
-  FFLAGS  = $(BINDIR) $(FLASHFILE)
-  DEBUGGER = $(RIOTBOARD)/$(BOARD)/dist/debug.sh
-  DEBUGSERVER = JLinkGDBServer -device CC2538SF53
-  RESET ?= $(RIOTBOARD)/$(BOARD)/dist/reset.sh
+  # Special flashing and reset scripts are required due to board hardware
+  export JLINK_DEVICE = CC2538SF53
+  export JLINK_IF = JTAG
+  export JLINK_RESET_FILE=$(RIOTBOARD)/$(BOARD)/dist/hw_reset.seg

Please put spaces around the `=`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11833#pullrequestreview-264110023
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190719/9aaffa3a/attachment.htm>


More information about the notifications mailing list