[riot-notifications] [RIOT-OS/RIOT] sys: add credman (D)TLS credential management module (#11564)

Martine Lenders notifications at github.com
Fri Jul 19 12:18:48 CEST 2019


miri64 commented on this pull request.



>      }
-
-    memcpy(&credentials[pos], credential, sizeof(*credential));
-    used++;
-    ret = CREDMAN_OK;
+    else {
+        memcpy(entry, credential, sizeof(credman_credential_t));

Side-note: `*entry = *credential` does the same (and should have the same ROM-size) but is type-safe, so I would prefer it like this. But this is not blocking.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11564#pullrequestreview-264130540
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190719/53296955/attachment.htm>


More information about the notifications mailing list