[riot-notifications] [RIOT-OS/RIOT] sys/auto_init: Allow to auto-initalize sensors and actuators independ of SAUL (#11871)

Semjon Kerner notifications at github.com
Sat Jul 20 11:02:53 CEST 2019


SemjonKerner commented on this pull request.

Looks way better than I imagined, well done.
But if I understand correctly, there is no way to de/activate auto_init for specific drivers only? If so, is this wanted?

Also I would appreciate more verbose documentation - but it's obvsly not blocking.

_I don't really want to ack/block this at all since I don't see the need for it and don't agree with all the arguments. I prefer another maintainer (@kaspar030?) takes the responsibility. Summon me if this PR get's stuck._

> @@ -1,3 +1,15 @@
+ifneq (,$(filter auto_init_actuators_%,$(USEMODULE)))

I may be wrong, but doesn't this mean using auto_init_actuators_\<actuator1\> will force auto_init for all USEMODULED actuators as well?
If this is desired behaviour, it's not really necessary to wildcard the modules.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11871#pullrequestreview-264489829
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190720/823163cd/attachment.htm>


More information about the notifications mailing list