[riot-notifications] [RIOT-OS/RIOT] tapsetup: require to be executed with sudo (#11889)

Martine Lenders notifications at github.com
Tue Jul 23 13:44:33 CEST 2019

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description
It is somewhat unlucky, that `tapsetup` basically executes sudo without the user potentially knowing about it (e.g. if they had NOPASSWD configured in their sudoers). Let's not do that and require the script to be executed with `sudo`. The executing user required for the ownership of the TAP interfaces can still be acquired via the `SUDO_USER` environment variable.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure
Run `dist/tools/tapsetup/tapsetup` with and without `sudo` (given output assumes you did not create a TAP bridge before):

$ dist/tools/tapsetup/tapsetup
need to export $SUDO_USER
$ sudo dist/tools/tapsetup/tapsetup
creating tapbr0
creating tap0
creating tap1
$ sudo dist/tools/tapsetup/tapsetup -d
deleting tapbr0

Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * tapsetup: require to be executed with sudo
  * README.md: adapt doc on tapsetup for new sudo requirement
  * native: adapt doc on tapsetup for new sudo requirement
  * doc: adapt doc on tapsetup for new sudo requirement
  * examples: adapt doc on tapsetup for new sudo requirement

-- File Changes --

    M README.md (2)
    M cpu/native/README.md (6)
    M dist/tools/tapsetup/tapsetup (61)
    M doc/doxygen/src/mainpage.md (2)
    M examples/ccn-lite-relay/README.md (2)
    M examples/dtls-echo/README.md (2)
    M examples/emcute_mqttsn/README.md (2)
    M examples/gnrc_networking/README.md (4)
    M examples/gnrc_tftp/README.md (2)
    M examples/ndn-ping/README.md (2)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190723/efaa2cee/attachment-0001.htm>

More information about the notifications mailing list