[riot-notifications] [RIOT-OS/RIOT] makefiles/riotboot: pass DEBUG_ADAPTER_ID to bootloader recipes (#11907)

Gaëtan Harter notifications at github.com
Wed Jul 24 17:57:28 CEST 2019


A short term one not really. Except maintaining a list of the variables that we pass. Because there is also `JLINK_SERIAL`, `SERIAL`, `PROGRAMMER_SERIAL` for other boards… (this is horrible I know).
It was also an issue for @bergzand who was using a different `RIOTBOARD` directory.

The `env -i` is required to remove everything that was set and exported in the compilation and would pollute calling `make` in `make`.
The real solution, remove global `export` and only do target specific exports or go through a separate included file in Makefile.base.

To go in that direction, it could also work to do `unset CFLAGS` (or whatever works in the shell) and all the variables that must be removed. It would help tracking what should be cleaned but be in a dangerous state where any export would break things.
At least we got rid of the `FLASHER` exports.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11907#issuecomment-514692620
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190724/39a0f252/attachment.htm>


More information about the notifications mailing list