[riot-notifications] [RIOT-OS/RIOT] drivers/cc110x: Complete rewrite from scratch (#10340)

Marian Buschsieweke notifications at github.com
Thu Jul 25 09:07:31 CEST 2019

> The point I want to make is that the added value of this driver into RIOT, as it is right now, is narrowed to your IPv6 case

This is not really true. The current driver is able to exchange layer 2 frames with other RIOT nodes, provided the antenna circuit and antenna can operate at the same base frequency and they use the same `cc110x_config_t`. This driver happily accepts 6LoWPAN frames (and thus provides IPv6 connectivity). But it just as well accepts everything else.

> The CC1101 was deployed, and is being deployed, for too many more use cases.

I fully agree that RIOT should be extended to also handle these use cases. I also 100% agree with reusing code of this driver wherever this makes sense. But I disagree with adding even more complexity to this PR which is already 4K lines of code.

IMHO: The goal of this PR is to replace the currently existing `cc110x` driver with one that:

1. Is basically a drop in replacement
1. Is easier to maintain and better documented
1. Uses the SPI interface more efficient than the old driver
1. Allows using popular 433MHz hardware without having to manually override specific configuration registers
1. Using whenever possible the default configuration parameters suggested by the data sheet. And whenever a non-default value has be used to document the reasons for that
1. Works more reliable than the original driver (e.g. also frames > 64B should be send/received correctly)

And as far as I'm concerned, the PR meets this goal. And I also think that this driver is a better starting point to extend RIOT to support other use cases of the CC110x as well, as it is better documented.

I also intend to improve this driver once merged, e.g. see the tracking in issue https://github.com/RIOT-OS/RIOT/issues/10373. Feel free to add feature requests there. But I really do not want to increase the problem this PR wants to solve, so that reviewing and testing this PR remains manageable. 

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190725/07d7e8f3/attachment.htm>

More information about the notifications mailing list