[riot-notifications] [RIOT-OS/RIOT] cc2420/gnrc_netif: Adds crc_valid to netif (#8276)

José Alamos notifications at github.com
Thu Jul 25 12:09:39 CEST 2019


jia200x commented on this pull request.



> @@ -90,7 +90,7 @@ static inline bool _already_received(gnrc_netif_t *netif,
 static gnrc_pktsnip_t *_recv(gnrc_netif_t *netif)
 {
     netdev_t *dev = netif->dev;
-    netdev_ieee802154_rx_info_t rx_info;
+    netdev_ieee802154_rx_info_t rx_info = { .crc_valid = 0 };

I think the driver should always set it. If the driver doesn't set it, it will be seen as invalid by the MAC layer.

If the radio doesn't support CRC calculation, this should be ignored via radio_caps (see #11473 ). If the driver doesn't provide a flag for the CRC (but does the calculations), it can be set to valid anyway.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8276#discussion_r307218861
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190725/ba188d45/attachment.htm>


More information about the notifications mailing list