[riot-notifications] [RIOT-OS/RIOT] cc2420/gnrc_netif: Adds crc_valid to netif (#8276)

Martine Lenders notifications at github.com
Thu Jul 25 12:31:34 CEST 2019


miri64 commented on this pull request.



> @@ -90,7 +90,7 @@ static inline bool _already_received(gnrc_netif_t *netif,
 static gnrc_pktsnip_t *_recv(gnrc_netif_t *netif)
 {
     netdev_t *dev = netif->dev;
-    netdev_ieee802154_rx_info_t rx_info;
+    netdev_ieee802154_rx_info_t rx_info = { .crc_valid = 0 };

`memset()` does exactly the same thing as the line above. Just without type check ;-P.

> This is independent to the fact the driver should always set it if it support automatic CRC calculation

So you agree now, that we *can't* guarantee the driver will set it? ;-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8276#discussion_r307227212
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190725/c6773010/attachment.htm>


More information about the notifications mailing list