[riot-notifications] [RIOT-OS/RIOT] cc2420/gnrc_netif: Adds crc_valid to netif (#8276)

Martine Lenders notifications at github.com
Thu Jul 25 13:38:33 CEST 2019


miri64 commented on this pull request.



> @@ -90,7 +90,7 @@ static inline bool _already_received(gnrc_netif_t *netif,
 static gnrc_pktsnip_t *_recv(gnrc_netif_t *netif)
 {
     netdev_t *dev = netif->dev;
-    netdev_ieee802154_rx_info_t rx_info;
+    netdev_ieee802154_rx_info_t rx_info = { .crc_valid = 0 };

Ok, after some offline discussion: would some documentation amendment e.g.

```C
    /**
     * @brief CRC was valid (when != 0)
     * @warning this is not implemented for all drivers yet,
     *          so some might not set it.
     */
    uint8_t crc_valid;
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8276#discussion_r307251080
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190725/b90efa9c/attachment.htm>


More information about the notifications mailing list