[riot-notifications] [RIOT-OS/RIOT] gnrc_netif_hdr: add setter for netif (minimal approach) (#11912)

MrKevinWeiss notifications at github.com
Thu Jul 25 14:08:13 CEST 2019


MrKevinWeiss commented on this pull request.

It looks fine and still passes tests, it seems like there is a difference in size but I guess it costs a bit to do a null check.
### native:
master
```
   text	   data	    bss	    dec	    hex	filename
 190164	    436	 130148	 320748	  4e4ec	RIOT/tests/gnrc_netif/bin/native/tests_gnrc_netif.elf
```


With PR
```
   text	   data	    bss	    dec	    hex	filename
 190284	    436	 130148	 320868	  4e564	RIOT/tests/gnrc_netif/bin/native/tests_gnrc_netif.elf
```
### samr21-xpro:
master:
```
   text	   data	    bss	    dec	    hex	filename
  63424	    152	  23896	  87472	  155b0	RIOT/tests/gnrc_netif/bin/samr21-xpro/tests_gnrc_netif.elf
```

With PR
```
   text	   data	    bss	    dec	    hex	filename
  63432	    152	  23896	  87480	  155b8	RIOT/tests/gnrc_netif/bin/samr21-xpro/tests_gnrc_netif.elf
```



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11912#pullrequestreview-266580860
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190725/4708ac82/attachment.htm>


More information about the notifications mailing list