[riot-notifications] [RIOT-OS/RIOT] cc2420/gnrc_netif: Adds crc_valid to netif (#8276)

Peter Kietzmann notifications at github.com
Thu Jul 25 14:21:46 CEST 2019


PeterKietzmann commented on this pull request.



> @@ -90,7 +90,7 @@ static inline bool _already_received(gnrc_netif_t *netif,
 static gnrc_pktsnip_t *_recv(gnrc_netif_t *netif)
 {
     netdev_t *dev = netif->dev;
-    netdev_ieee802154_rx_info_t rx_info;
+    netdev_ieee802154_rx_info_t rx_info = { .crc_valid = 0 };

> memset() does exactly the same thing as the line above. Just without type check ;-P

We should set the whole `netdev_ieee802154_rx_info_t` struct to zero and not just `.crc` (which can be easily done using `memset` ) 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8276#discussion_r307266311
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190725/36edf1ab/attachment-0001.htm>


More information about the notifications mailing list