[riot-notifications] [RIOT-OS/RIOT] cc2420/gnrc_netif: Adds crc_valid to netif (#8276)

Martine Lenders notifications at github.com
Thu Jul 25 14:31:50 CEST 2019

miri64 commented on this pull request.

> @@ -90,7 +90,7 @@ static inline bool _already_received(gnrc_netif_t *netif,
 static gnrc_pktsnip_t *_recv(gnrc_netif_t *netif)
     netdev_t *dev = netif->dev;
-    netdev_ieee802154_rx_info_t rx_info;
+    netdev_ieee802154_rx_info_t rx_info = { .crc_valid = 0 };

> In that case, .crc needs to be set to a value !=0. Where does this happen? Or did I misunderstand something?

It the drivers. However, this PR only ports the `cc2420`. That's why I and @jia200x suggested that @roberthartung adds the big fat warning to the doc of that field. Requiring all the drivers to be ported in this PR would explode this PR.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190725/f4de5a70/attachment.htm>

More information about the notifications mailing list