[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6: use gnrc_netif_hdr_get/set_netif() (#11918)

Martine Lenders notifications at github.com
Thu Jul 25 15:59:15 CEST 2019

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description
This splits out the usage of `gnrc_netif_hdr_get_netif()`/`gnrc_netif_hdr_set_netif()` of IPv6 related stuff of GNRC out of #10661 (except for ICMPv6 echo, see #11916).

Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure
The following tests should still pass
- `tests/gnrc_ndp`
- `tests/gnrc_ipv6_nib`
- `tests/gnrc_ipv6_nib_6ln`

It also does not hurt to do all the tests in [Task 10 of the release specs](https://github.com/RIOT-OS/Release-Specs/blob/master/10-icmpv6-error/10-icmpv6-error.md), however one of subtask 1-9 should be enough as only the sending routine of the `gnrc_icmpv6_error` module is changed.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references
Split out of #10661.
Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * gnrc_ipv6: use gnrc_netif_hdr_set_netif()
  * gnrc_ndp: use gnrc_netif_hdr_set_netif()
  * gnrc_ipv6: use gnrc_netif_hdr_get_netif()
  * gnrc_icmpv6_error: use gnrc_netif_hdr_get/set_netif()

-- File Changes --

    M sys/net/gnrc/network_layer/icmpv6/error/gnrc_icmpv6_error.c (6)
    M sys/net/gnrc/network_layer/ipv6/gnrc_ipv6.c (4)
    M sys/net/gnrc/network_layer/ipv6/nib/nib.c (4)
    M sys/net/gnrc/network_layer/ndp/gnrc_ndp.c (2)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190725/73133204/attachment-0001.htm>

More information about the notifications mailing list