[riot-notifications] [RIOT-OS/RIOT] cpu/atmega_common: pseudomodule-based pin change interrupt implementation (#11122)
notifications at github.com
Fri Jul 26 08:00:10 CEST 2019
OK, apart from the the test (which should expect `gpio_init_int()` to fail on pins not supported by a board) I'd say ACK. How about splitting the test off in a separate PR, squash this PR and merge?
To me it also is questionable if I am actually allowed to ACK the code of the test, as I authored most of it. Maybe I can open a separate PR for that and you (@roberthartung) could review the test?
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications