[riot-notifications] [RIOT-OS/RIOT] cpu/atmega_common: pseudomodule-based pin change interrupt implementation (#11122)

Marian Buschsieweke notifications at github.com
Fri Jul 26 08:00:10 CEST 2019


OK, apart from the the test (which should expect `gpio_init_int()` to fail on pins not supported by a board) I'd say ACK. How about splitting the test off in a separate PR, squash this PR and merge?

To me it also is questionable if I am actually allowed to ACK the code of the test, as I authored most of it. Maybe I can open a separate PR for that and you (@roberthartung) could review the test?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11122#issuecomment-515320708
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190725/d84460a4/attachment.htm>


More information about the notifications mailing list