[riot-notifications] [RIOT-OS/RIOT] cpu/esp32: activate cpp feature (#11922)
notifications at github.com
Fri Jul 26 11:42:40 CEST 2019
@cladmi, @kaspar030 Since someone was asking for using `cpp` feature with ESP32, I tried to activate it. Principally, it is working when `pthread` module is used and `libstdc++` is linked.
However, to avoid that module `pthread` and `libstdc++` are used always even if they aren't needed, I tried to use them only, if feature `cpp` is required. Since there is no pseudomodule `cpp`, I just used `FEATURE_REQUIRED` in `cpu/esp32/Makefile.dep`:
ifneq (,$(filter cpp,$(FEATURES_REQUIRED)))
USEMODULE += pthread
BASELIBS += -lstdc++
Unfortunatly, static tests fail with
Running './dist/tools/buildsystem_sanity_check/check.sh' x
Invalid build system patterns found by ./dist/tools/buildsystem_sanity_check/check.sh:
Modules should not check the content of FEATURES_PROVIDED/_REQUIRED/OPTIONAL
cpu/esp32/Makefile.dep:ifneq (,$(filter cpp,$(FEATURES_REQUIRED)))
How should I realize this dependency? Or should I add module `pthread` and link `libstdc++` always, even if they are not needed?
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications