[riot-notifications] [RIOT-OS/RIOT] cpu/esp32: activate cpp feature (#11922)

Gunar Schorcht notifications at github.com
Fri Jul 26 11:42:40 CEST 2019


@cladmi, @kaspar030 Since someone was asking for using `cpp` feature with ESP32, I tried to activate it. Principally, it is working when `pthread` module is used and `libstdc++` is linked.

However, to avoid that module `pthread` and `libstdc++` are used always even if they aren't needed, I tried to use them only, if feature `cpp` is required. Since there is no pseudomodule `cpp`, I just used `FEATURE_REQUIRED` in `cpu/esp32/Makefile.dep`:
```
ifneq (,$(filter cpp,$(FEATURES_REQUIRED)))
    USEMODULE += pthread
    BASELIBS += -lstdc++
endif
```
Unfortunatly, static tests fail with 
```
Running './dist/tools/buildsystem_sanity_check/check.sh' x
Command output:
	Invalid build system patterns found by ./dist/tools/buildsystem_sanity_check/check.sh:
	Modules should not check the content of FEATURES_PROVIDED/_REQUIRED/OPTIONAL
		cpu/esp32/Makefile.dep:ifneq (,$(filter cpp,$(FEATURES_REQUIRED)))
```
How should I realize this dependency? Or should I add module `pthread` and link `libstdc++` always, even if they are not needed?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11922#issuecomment-515383563
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190726/4af9eb54/attachment.htm>


More information about the notifications mailing list