[riot-notifications] [RIOT-OS/RIOT] makefiles: Introduce GIT_VERSION and use it for RIOT_VERSION (#11881)

Martine Lenders notifications at github.com
Fri Jul 26 13:36:17 CEST 2019


miri64 approved this pull request.

ACK, I tested building and running `examples/hello-world`

- on master (should give e.g. `2019.10-devel-128-g7d381`, i.e. should not append the branch name and no extra `-` at the end)
- on a detached HEAD (should give e.g. `2019.10-devel-128-g7d381-HEAD`)
- on a branch (should give e.g. `2019.10-devel-128-g7d381-test-pr-11881`, i.e. with the branch name appended, prefixed with a `-`)
- on a release tag (should just print the release name e.g. `2019.07`)
- the content of a [release tar ball](https://github.com/RIOT-OS/RIOT/archive/2019.07.tar.gz) (should just print the release name e.g. `2019.07`).

For all cherry-picked the commits from this PR on top (or just applied as patch in the tar ball case `git -C ../RIOT diff HEAD~3 > patch.txt; patch -p1 < patch.txt`).

All had the expected output.

I tried to verify the speed updates you claimed:

In this PR

```
$ time for i in {0..100}; do RIOT_CI_BUILD=1 make --no-print-directory -C examples/hello-world/ info-debug-variable-CFLAGS_WITH_MACROS >/dev/null 2>/dev/null; done

real	0m35,414s
user	0m27,379s
sys	0m11,662s
$ time for i in {0..100}; do make --no-print-directory -C examples/hello-world/ info-debug-variable-CFLAGS_WITH_MACROS >/dev/null 2>/dev/null; done

real	0m47,847s
user	0m37,648s
sys	0m13,471s
$ time for i in {0..100}; do RIOT_CI_BUILD=1 make --no-print-directory -C examples/hello-world/ clean >/dev/null 2>/dev/null; done

real	0m36,378s
user	0m27,814s
sys	0m12,369s
```

and a significant speed boost is visible when not using `RIOT_VERSION` (done on `git reset --hard HEAD~3` form this PR as `HEAD`):

```
```



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11881#pullrequestreview-267136816
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190726/6788ec66/attachment.htm>


More information about the notifications mailing list