[riot-notifications] [RIOT-OS/RIOT] gnrc_icmpv6_echo: use gnrc_netif_hdr_set_netif() (#11916)

Martine Lenders notifications at github.com
Fri Jul 26 16:49:41 CEST 2019


miri64 commented on this pull request.



>              data->hostname = arg;
 #ifdef MODULE_SOCK_DNS
             if (sock_dns_query(data->hostname, &data->host, AF_INET6) == 0) {
                 continue;
             }
 #endif
-            data->iface = ipv6_addr_split_iface(data->hostname);
-            if (data->iface < KERNEL_PID_UNDEF) {
+            iface = ipv6_addr_split_iface(data->hostname);
+            if (iface > KERNEL_PID_UNDEF) {

See https://github.com/RIOT-OS/RIOT/pull/11916/commits/d1abb29665d7f73eb7ae6ca3a45f107b528fe88e. I would recommend to redo the test though (don't have the hardware at hand to to so myself atm)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11916#discussion_r307777687
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190726/eec621a3/attachment.htm>


More information about the notifications mailing list