[riot-notifications] [RIOT-OS/RIOT] sys: single interrupt handler thread for interrupts in modules with blocking functions (#10555)

Marian Buschsieweke notifications at github.com
Sat Jul 27 10:22:47 CEST 2019


maribu commented on this pull request.



> + * priority. Each interrupt event object can be registered on the handler
+ * only once. That is, if the same interrupt occurs multiple times, only its
+ * first occurence is placed to the pending interrupt queue and is handled.
+ *
+ * When the interrupt handler thread gets the CPU, it processes all pending
+ * interrupt events in the order of their occurence before it yields.
+ *
+ * ## Usage
+ *
+ * This interrupt handler thread can be used not only for blocking functions
+ * such as SPI or I2C access, but also for other blocking functions. Please
+ * note, however, that the handling of interrupts is serialized by this
+ * module.
+ *
+ * To use the interrupt handler, the using module has to define a static
+ * interrupt event object of type #irq_event_t for each interrupt source. The

I'd avoid the term "object", as this term is often understood as in "object oriented programming". Also "static" might be unclear, as the keyword `static` can either be used to control whether or not a symbol for linking is created (in front of global variables/functions), or if a local variable is allocated on the stack or in data/bss. Maybe something like "statically allocated structure" would be clearer?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10555#pullrequestreview-267461118
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190727/feaaf25d/attachment-0001.htm>


More information about the notifications mailing list