[riot-notifications] [RIOT-OS/RIOT] makefiles: Introduce GIT_VERSION and use it for RIOT_VERSION (#11881)

Gaëtan Harter notifications at github.com
Mon Jul 29 09:05:24 CEST 2019


Thank you for the review.

> * on a detached HEAD (should give e.g. `2019.10-devel-128-g7d381-HEAD`)
> 
> * on a release tag (should just print the release name e.g. `2019.07`)

I did not thought about these ones, and the release tag is one of the most important one. I will do another PR to document these in `git_version.inc.mk`.

> * the content of a [release tar ball](https://github.com/RIOT-OS/RIOT/archive/2019.07.tar.gz) (should just print the release name e.g. `2019.07`).

I indeed forgot to show this was not changed. Good catch. 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11881#issuecomment-515871705
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190729/2206e346/attachment.htm>


More information about the notifications mailing list