[riot-notifications] [RIOT-OS/RIOT] makefiles: Introduce GIT_VERSION and use it for RIOT_VERSION (#11881)
notifications at github.com
Mon Jul 29 09:42:17 CEST 2019
Indeed, if there is a `VERSION` file, the `RIOT_VERSION` is taken from it even in `git`. It was how I designed and implemented it in the first place.
Now that you say it, with the current and previous behavior, the `git` version indeed has `-HEAD` for a tag:
make --no-print-directory -C examples/hello-world/ info-debug-variable-RIOT_VERSION
I could propose to change this. Which then would make being on `master` and on `HEAD` show the same thing.
We could also remove the `branch` completely
When I noticed the branch name was in the version, it felt for me a bit off somehow. It is a source on non reproducibility and local machine information.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications