[riot-notifications] [RIOT-OS/RIOT] net/nanocoap: Buffer API Block helper functions (#11024)

Francisco notifications at github.com
Mon Jul 29 14:05:47 CEST 2019


fjmolinas commented on this pull request.



>  {
-    unsigned szx = _size2szx(slicer->end - slicer->start);
-    unsigned blknum = _slicer_blknum(slicer);
+    coap_block1_t block;
+
+    coap_block_object_init(&block, _slicer_blknum(slicer),

Here `coap_block_object_init` receives a `bool more` but in it declaration its type is `int`. Shouldn't it be a bool in both cases? Change the documentation accordingly if its the case.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11024#pullrequestreview-267736862
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190729/a23455e5/attachment.htm>


More information about the notifications mailing list