[riot-notifications] [RIOT-OS/RIOT] shell/ping6: Incorrect handling of unexpected pongs (#11519)
notifications at github.com
Tue Jul 30 22:40:20 CEST 2019
Yes the second case (pinging two different nodes) is fixed by source address checking, but not the first case.
I don't actually know what is the intended use of `id` or whether it's supposed to be unique per node or unique per invocation. But if we make it unique per invocation then it helps solve the first case:
* invoke `ping6` to send a ping to any node
* invoke `ping6` again to ping the same node
* any delayed pongs from the first invocation will be counted by the second invocation. Maybe not everyone agrees that this is wrong behavior, but if we can prevent it I think we should.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications