[riot-notifications] [RIOT-OS/RIOT] pkg/tinydtls: documents usage and configuration options (#11936)

Martine Lenders notifications at github.com
Wed Jul 31 17:09:22 CEST 2019


miri64 requested changes on this pull request.



> \ No newline at end of file
+ *
+ * Usage
+ * -----
+ *
+ * Add as a package in your application Makefile:

`your application's Makefile` or `Makefile of your application`

> @@ -0,0 +1,79 @@
+/*

Where is this header included? If it is not supposed to, but the defines are only used with `CFLAGS`, than I prefer to add the `tinydtls_config` group to `tinydtls`'s `doc.txt`.

> +#ifndef DTLS_SECURITY_MAX
+#define DTLS_SECURITY_MAX   (DTLS_HANDSHAKE_MAX + DTLS_PEER_MAX)
+#endif
+
+/**
+ * @brief The maximum number of hash functions that can be used in parallel
+ */
+#ifndef DTLS_HASH_MAX
+#define DTLS_HASH_MAX       (3 * DTLS_PEER_MAX)
+#endif
+
+/**
+ * @brief The number of retransmissions of any DTLS record
+ *
+ * The 802.15.4 ACK can provoke very fast re-transmissions with a value
+ * higher than one. This is a temporary bad behavior for the RIOT MAC

??!? What do IEEE 802.15.4 retransmissions to do with encryption on the transport? Is this supposed to be a `@warning`? In any way, I don't think this belongs here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11936#pullrequestreview-269079212
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190731/ef0d63ec/attachment-0001.htm>


More information about the notifications mailing list