[riot-notifications] [RIOT-OS/RIOT] Driver for AT24CXXX EEPROM (#11929)

benpicco notifications at github.com
Wed Jul 31 23:56:15 CEST 2019


benpicco commented on this pull request.



> +extern "C" {
+#endif
+
+/**
+ * @name    AT24CXXX constants
+ * @{
+ */
+
+/** 14 bit for AT24C128, 15 bit for AT24C256 */
+#define AT24CXXX_ADDR_LEN          (2UL)
+/** page size */
+#define AT24CXXX_PAGE_SIZE         (64UL)
+/** number of poll attempts */
+#define AT24CXXX_MAX_POLLS         (6UL)
+/** delay between two poll attempts */
+#define AT24CXXX_POLL_DELAY_MS     (1UL)

might as well make this `AT24CXXX_POLL_DELAY_US` and remove that multiplication with `US_PER_MS` on each call to ease the burden on the reader.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11929#pullrequestreview-269304656
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190731/e6b85a69/attachment.htm>


More information about the notifications mailing list