[riot-notifications] [RIOT-OS/RIOT] cpu/cc26x0: implement uart_mode() (#11612)

MrKevinWeiss notifications at github.com
Mon Jun 3 12:02:33 CEST 2019


MrKevinWeiss commented on this pull request.

Looks good so far. I will test it today.

> @@ -72,8 +72,8 @@ typedef struct {
 #define UART_FR_RXFF            0x40
 #define UART_FR_TXFE            0x80
 
-#define UART_LCRH_PEN           0x1
-#define UART_LCRH_EPS           0x2
+#define UART_LCRH_PEN           0x2
+#define UART_LCRH_EPS           0x4
 #define UART_LCRH_RXFE          0x4

Confirmed with the datasheet, Maybe remove the `UART_LCRH_RXFE` since it really part of the `FR` register.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11612#pullrequestreview-244786189
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190603/4a4b4b7f/attachment.html>


More information about the notifications mailing list