[riot-notifications] [RIOT-OS/RIOT] [TRACKING] buildsystem: introduce "make rawterm" (#11099)

Gaƫtan Harter notifications at github.com
Mon Jun 3 13:03:07 CEST 2019


cladmi requested changes on this pull request.

This needs some adequate testing procedure as it currently breaks existing boards behavior.

In master
```
BOARD=ruuvitag make --no-print-directory -C examples/hello-world/ term
/home/harter/work/git/RIOT/dist/tools/jlink/jlink.sh term_rtt
### Starting RTT terminal ###
Twisted not available, please install it if you want to use pyterm's JSON capabilities
2019-06-03 12:54:05,915 - WARNING # Host name for TCP connection is missing, defaulting to "localhost"
2019-06-03 12:54:05,915 - INFO # Connect to localhost:19021
2019-06-03 12:54:05,920 - ERROR # Something went wrong connecting to localhost:19021
/home/harter/work/git/RIOT/dist/tools/jlink/jlink.sh: 241: kill: No such process
```

With this PR

```
BOARD=ruuvitag make --no-print-directory -C examples/hello-world/ term
/home/harter/work/git/RIOT/dist/tools/pyterm/pyterm -p "/dev/ttyACM0" -b "115200"
Twisted not available, please install it if you want to use pyterm's JSON capabilities
2019-06-03 12:53:59,548 - INFO # Connect to serial port /dev/ttyACM0
2019-06-03 12:53:59,549 - ERROR # Cannot connect to serial port /dev/ttyACM0: could not open port /dev/ttyACM0: [Errno 2] No such file or directory: '/dev/ttyACM0'
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:550: recipe for target 'term' failed
```

Also `jlink.sh` still uses a non raw configuration for `stdio-rtt`

The pull request contains unrelated changes and some of the fix should really be split before to allow reviewing.

Some new required command require changing the `docker` image for working which should be addressed with the minimal PR requiring it.

I added the WIP state.

> @@ -16,11 +16,29 @@ RIOT_TERMINAL ?= pyterm
 ifeq ($(RIOT_TERMINAL),pyterm)
   TERMPROG  ?= $(RIOTTOOLS)/pyterm/pyterm
   TERMFLAGS ?= -p "$(PORT)" -b "$(BAUD)"
-else ifeq ($(RIOT_TERMINAL),socat)
-  SOCAT_OUTPUT ?= -
-  TERMPROG ?= $(RIOT_TERMINAL)
-  TERMFLAGS ?= $(SOCAT_OUTPUT) open:$(PORT),b$(BAUD),echo=0,raw
+else ifeq ($(RIOT_TERMINAL),rlwrap)

This is unrelated to supporting `rawterm`.

> @@ -16,11 +16,29 @@ RIOT_TERMINAL ?= pyterm
 ifeq ($(RIOT_TERMINAL),pyterm)
   TERMPROG  ?= $(RIOTTOOLS)/pyterm/pyterm
   TERMFLAGS ?= -p "$(PORT)" -b "$(BAUD)"
-else ifeq ($(RIOT_TERMINAL),socat)
-  SOCAT_OUTPUT ?= -
-  TERMPROG ?= $(RIOT_TERMINAL)
-  TERMFLAGS ?= $(SOCAT_OUTPUT) open:$(PORT),b$(BAUD),echo=0,raw
+else ifeq ($(RIOT_TERMINAL),rlwrap)
+  TERMPROG  ?= $(RIOT_TERMINAL)
+  RLWRAP_PROMPT ?= -pPurple -S 'RIOT $$ '

Why even adding a prompt ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11099#pullrequestreview-244809971
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190603/ce6b5e1c/attachment.html>


More information about the notifications mailing list