[riot-notifications] [RIOT-OS/RIOT] [TRACKING] buildsystem: introduce "make rawterm" (#11099)

Cenk Gündoğan notifications at github.com
Mon Jun 3 13:22:52 CEST 2019


cgundogan requested changes on this pull request.



> @@ -19,6 +19,8 @@ PORT_LINUX ?= /dev/ttyUSB0
 # This does not make a lot of sense, but it has the same value as the previous code
 PORT_DARWIN ?= /dev/tty.usbserial-ARM
 
+# The -tg option is specific to pyterm so we are forced to use it.
+RIOT_TERMINAL = pyterm

Can't you also use simply expanded variables `:=` here and in all following cases below? There's no need for recursions as it appears to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11099#pullrequestreview-244818954
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190603/27232e80/attachment.html>


More information about the notifications mailing list